FIX: testutil decorator #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facaiy
approved these changes
Mar 15, 2019
Member
facaiy
left a comment
facaiy
left a comment
There was a problem hiding this comment.
It's a tensorflow bug, but let's get rid of it now that a workaround solution works.
Squadrick
pushed a commit
to Squadrick/addons
that referenced
this pull request
Mar 26, 2019
* DOC: Add pip install * FIX: un-named argument for new decorator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our first catch from nightly CI...
Summary:
New decorator introcduced in tensorflow/tensorflow@c27909e#diff-f541c00fcae53468339272b7c92a67a4 is causing this test to fail because the decorator is never provided an argument as seen here
I believe this is a bug, but since we're using a private test API, I wasn't sure if its worth an issue (maybe just a bug fix PR?)